From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next v12 1/5] net: Introduce generic failover module
Date: Sat, 26 May 2018 09:43:16 +0200
Message-ID: <20180526074316.GB4288@nanopsycho.orion>
References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com>
 <1527180917-39737-2-git-send-email-sridhar.samudrala@intel.com>
 <20180525153744.2b53c449@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>, mst@redhat.com,
        davem@davemloft.net, netdev@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
        alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com,
        loseweigh@gmail.com, aaron.f.brown@intel.com,
        anjali.singhai@intel.com
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f193.google.com ([209.85.128.193]:36487 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1031131AbeEZHnc (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 26 May 2018 03:43:32 -0400
Received: by mail-wr0-f193.google.com with SMTP id k5-v6so12652696wrn.3
        for <netdev@vger.kernel.org>; Sat, 26 May 2018 00:43:32 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180525153744.2b53c449@xeon-e3>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Sat, May 26, 2018 at 12:37:44AM CEST, stephen@networkplumber.org wrote:
>On Thu, 24 May 2018 09:55:13 -0700
>Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
>
>
>> +	spin_lock(&failover_lock);
>
>Since register is not in fast path, this should be a mutex?

I don't get it. Why would you prefer mutex over spinlock here?