From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Date: Sat, 26 May 2018 09:51:56 +0200 Message-ID: <20180526075156.GC4288@nanopsycho.orion> References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com> <1527180917-39737-3-git-send-email-sridhar.samudrala@intel.com> <20180525153456.28b44c7c@xeon-e3> <20180525162839.3c7028e1@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: alexander.h.duyck@intel.com, virtio-dev@lists.oasis-open.org, mst@redhat.com, kubakici@wp.pl, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, loseweigh@gmail.com, anjali.singhai@intel.com, aaron.f.brown@intel.com, davem@davemloft.net To: "Samudrala, Sridhar" Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org Sat, May 26, 2018 at 09:22:18AM CEST, sridhar.samudrala@intel.com wrote: >On 5/25/2018 4:28 PM, Stephen Hemminger wrote: >> On Fri, 25 May 2018 16:11:47 -0700 >> "Samudrala, Sridhar" wrote: >> >> > On 5/25/2018 3:34 PM, Stephen Hemminger wrote: >> > > On Thu, 24 May 2018 09:55:14 -0700 >> > > Sridhar Samudrala wrote: >> > > > --- a/drivers/net/hyperv/Kconfig >> > > > +++ b/drivers/net/hyperv/Kconfig >> > > > @@ -2,5 +2,6 @@ config HYPERV_NET >> > > > tristate "Microsoft Hyper-V virtual network driver" >> > > > depends on HYPERV >> > > > select UCS2_STRING >> > > > + select FAILOVER >> > > When I take a working kernel config, add the patches then do >> > > make oldconfig >> > > >> > > It is not autoselecting FAILOVER, it prompts me for it. This means >> > > if user says no then a non-working netvsc device is made. >> > I see >> > Generic failover module (FAILOVER) [M/y/?] (NEW) >> > >> > So the user is given an option to either build as a Module or part of the >> > kernel. 'n' is not an option. >> With most libraries there is no prompt at all. > >Not sure what you meant by this. >Without any patches applied, i had a .config file with HYPERV_NET configured >as a module. >Then after applying the first 2 patches in this series, i did a > make oldconfig >and i see the above prompt. > >Are you saying that on some distros, 'make oldconfig creates a .config >file without any prompt and FAILOVER is not getting selected even when HYPERV_NET >is enabled? > > Well the thing is that for a user, it makes no sense to select "FAILOVER" by hand. It is a lib, so it should be only select it by a user. It has no sense to have it turned on by hand - no lib user. You can achieve that by simply removing "help" for the Kconfig item. Same thing for "NET_FAILOVER".