From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH v2 00/11] Modify action API for implementing lockless actions Date: Sun, 27 May 2018 19:57:39 +0200 Message-ID: <20180527175739.GA3337@nanopsycho> References: <1527439298-22306-1-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@mellanox.com, ast@kernel.org, daniel@iogearbox.net, kliteyn@mellanox.com To: Vlad Buslov Return-path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:37377 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032821AbeE0R6C (ORCPT ); Sun, 27 May 2018 13:58:02 -0400 Received: by mail-wr0-f196.google.com with SMTP id i12-v6so16763482wrc.4 for ; Sun, 27 May 2018 10:58:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1527439298-22306-1-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: Sun, May 27, 2018 at 06:41:27PM CEST, vladbu@mellanox.com wrote: [...] >Changes from V1 to V2: >- Removed redundant actions ops lookup during delete. >- Merge action ops delete definition and implementation. >- Assume all actions have delete implemented and don't check for it > explicitly. >- Resplit action lookup/release code to prevent memory leaks in > individual patches. >- Make __tcf_idr_check function static >- Remove unique idr insertion function. Change original idr insert to do > the same thing. >- Merge changes that take reference to action when performing lookup and > changes that account for this additional reference when dumping action > to user space into single patch. >- Change convoluted commit message. >- Rename "unlocked" to "rtnl_held" for clarity. >- Remove estimator lock add patch. >- Refactor action check-alloc code into standalone function. >- Rename tcf_idr_find_delete to tcf_idr_delete_index. >- Rearrange variable definitions in tc_action_delete. >- Add patch that refactors action API code to use array of pointers to > actions instead of intrusive linked list. >- Expand cover letter. With 11 patches, I'm unable to follow the changes in this description. Could you please write the changes to each individual patch? What I do is I write changes for each patch under "---" (there are two "---" lines in each patch then. Then I also copy the changes descriptions to the cover letter. [...]