* Re: [PATCH net-next] vrf: add CRC32c offload to device features
2018-05-24 15:49 [PATCH net-next] vrf: add CRC32c offload to device features Davide Caratti
@ 2018-05-24 19:54 ` Marcelo Ricardo Leitner
2018-05-25 19:36 ` David Miller
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-05-24 19:54 UTC (permalink / raw)
To: Davide Caratti; +Cc: David Ahern, Vlad Yasevich, linux-sctp, netdev
On Thu, May 24, 2018 at 05:49:35PM +0200, Davide Caratti wrote:
> SCTP sockets originated in a VRF can improve their performance if CRC32c
> computation is delegated to underlying devices: update device features,
> setting NETIF_F_SCTP_CRC. Iterating the following command in the topology
> proposed with [1],
>
> # ip vrf exec vrf-h2 netperf -H 192.0.2.1 -t SCTP_STREAM -- -m 10K
>
> the measured throughput in Mbit/s improved from 2395 ± 1% to 2720 ± 1%.
>
> [1] https://www.spinics.net/lists/netdev/msg486007.html
>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> drivers/net/vrf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
> index 90b5f3900c22..f93547f257fb 100644
> --- a/drivers/net/vrf.c
> +++ b/drivers/net/vrf.c
> @@ -1254,7 +1254,7 @@ static void vrf_setup(struct net_device *dev)
>
> /* enable offload features */
> dev->features |= NETIF_F_GSO_SOFTWARE;
> - dev->features |= NETIF_F_RXCSUM | NETIF_F_HW_CSUM;
> + dev->features |= NETIF_F_RXCSUM | NETIF_F_HW_CSUM | NETIF_F_SCTP_CRC;
> dev->features |= NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA;
>
> dev->hw_features = dev->features;
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] vrf: add CRC32c offload to device features
2018-05-24 15:49 [PATCH net-next] vrf: add CRC32c offload to device features Davide Caratti
2018-05-24 19:54 ` Marcelo Ricardo Leitner
@ 2018-05-25 19:36 ` David Miller
2018-05-25 20:06 ` David Ahern
2018-05-29 2:55 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-05-25 19:36 UTC (permalink / raw)
To: dcaratti; +Cc: dsa, vyasevich, marcelo.leitner, linux-sctp, netdev
From: Davide Caratti <dcaratti@redhat.com>
Date: Thu, 24 May 2018 17:49:35 +0200
> SCTP sockets originated in a VRF can improve their performance if CRC32c
> computation is delegated to underlying devices: update device features,
> setting NETIF_F_SCTP_CRC. Iterating the following command in the topology
> proposed with [1],
>
> # ip vrf exec vrf-h2 netperf -H 192.0.2.1 -t SCTP_STREAM -- -m 10K
>
> the measured throughput in Mbit/s improved from 2395 ± 1% to 2720 ± 1%.
>
> [1] https://www.spinics.net/lists/netdev/msg486007.html
>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
David A., please review.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] vrf: add CRC32c offload to device features
2018-05-24 15:49 [PATCH net-next] vrf: add CRC32c offload to device features Davide Caratti
2018-05-24 19:54 ` Marcelo Ricardo Leitner
2018-05-25 19:36 ` David Miller
@ 2018-05-25 20:06 ` David Ahern
2018-05-29 2:55 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Ahern @ 2018-05-25 20:06 UTC (permalink / raw)
To: Davide Caratti, Vlad Yasevich, Marcelo Ricardo Leitner; +Cc: linux-sctp, netdev
On 5/24/18 9:49 AM, Davide Caratti wrote:
> SCTP sockets originated in a VRF can improve their performance if CRC32c
> computation is delegated to underlying devices: update device features,
> setting NETIF_F_SCTP_CRC. Iterating the following command in the topology
> proposed with [1],
>
> # ip vrf exec vrf-h2 netperf -H 192.0.2.1 -t SCTP_STREAM -- -m 10K
>
> the measured throughput in Mbit/s improved from 2395 ± 1% to 2720 ± 1%.
>
> [1] https://www.spinics.net/lists/netdev/msg486007.html
>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---
> drivers/net/vrf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: David Ahern <dsa@cumulusnetworks.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] vrf: add CRC32c offload to device features
2018-05-24 15:49 [PATCH net-next] vrf: add CRC32c offload to device features Davide Caratti
` (2 preceding siblings ...)
2018-05-25 20:06 ` David Ahern
@ 2018-05-29 2:55 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-05-29 2:55 UTC (permalink / raw)
To: dcaratti; +Cc: dsa, vyasevich, marcelo.leitner, linux-sctp, netdev
From: Davide Caratti <dcaratti@redhat.com>
Date: Thu, 24 May 2018 17:49:35 +0200
> SCTP sockets originated in a VRF can improve their performance if CRC32c
> computation is delegated to underlying devices: update device features,
> setting NETIF_F_SCTP_CRC. Iterating the following command in the topology
> proposed with [1],
>
> # ip vrf exec vrf-h2 netperf -H 192.0.2.1 -t SCTP_STREAM -- -m 10K
>
> the measured throughput in Mbit/s improved from 2395 ± 1% to 2720 ± 1%.
>
> [1] https://www.spinics.net/lists/netdev/msg486007.html
>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread