From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG Date: Mon, 28 May 2018 09:33:03 +0300 Message-ID: <20180528063303.GA15094@splinter.mtl.com> References: <20180527064841.32199-1-idosch@mellanox.com> <20180528035558.GD18029@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ido Schimmel , netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, mlxsw@mellanox.com To: Andrew Lunn Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38781 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753395AbeE1GdH (ORCPT ); Mon, 28 May 2018 02:33:07 -0400 Content-Disposition: inline In-Reply-To: <20180528035558.GD18029@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, May 28, 2018 at 05:55:58AM +0200, Andrew Lunn wrote: > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > index ca38a30fbe91..adc6ab2cf429 100644 > > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > @@ -4433,6 +4433,11 @@ static int mlxsw_sp_netdevice_port_upper_event(struct net_device *lower_dev, > > NL_SET_ERR_MSG_MOD(extack, "Can not put a VLAN on an OVS port"); > > return -EINVAL; > > } > > + if (is_vlan_dev(upper_dev) && > > + vlan_dev_vlan_id(upper_dev) == 1) { > > + NL_SET_ERR_MSG_MOD(extack, "Creating a VLAN device with VID 1 is unsupported: VLAN 1 carries untagged traffic"); > > + return -EINVAL; > > + } > > Hi Ido > > Would ENOTSUPP be a better return code. VLAN 1 is valid, you just > don't support it. OK, makes sense. We currently use EINVAL for such errors, but we can convert to EOPNOTSUPP in net-next. Thanks