Re: [PATCH v3 11/11] net: sched: change action API to use array of pointers to actions

Jiri Pirko
2018-05-30T20:37:49Z

Sun, May 27, 2018 at 11:17:29PM CEST, vladbu@mellanox.com wrote:
>Act API used linked list to pass set of actions to functions. It is
>intrusive data structure that stores list nodes inside action structure
>itself, which means it is not safe to modify such list concurrently.
>However, action API doesn't use any linked list specific operations on this
>set of actions, so it can be safely refactored into plain pointer array.
>
>Refactor action API to use array of pointers to tc_actions instead of
>linked list. Change argument 'actions' type of exported action init,
>destroy and dump functions.
>
>Signed-off-by: Vlad Buslov <vladbu@mellanox.com>

Even with the nit Marcelo found, this looks fine to me.

Acked-by: Jiri Pirko <jiri@mellanox.com>