From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH v3 07/11] net: sched: implement reference counted action release Date: Mon, 28 May 2018 16:30:00 +0200 Message-ID: <20180528143000.GF2173@nanopsycho> References: <20180527175739.GA3337@nanopsycho> <1527455849-22327-1-git-send-email-vladbu@mellanox.com> <1527455849-22327-8-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, kliteyn@mellanox.com To: Vlad Buslov Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:36005 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161743AbeE1OaY (ORCPT ); Mon, 28 May 2018 10:30:24 -0400 Received: by mail-wm0-f67.google.com with SMTP id v131-v6so13408626wma.1 for ; Mon, 28 May 2018 07:30:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1527455849-22327-8-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: Sun, May 27, 2018 at 11:17:25PM CEST, vladbu@mellanox.com wrote: >Implement helper delete function that uses new action ops 'delete', instead >of destroying action directly. This is required so act API could delete >actions by index, without holding any references to action that is being >deleted. > >Implement function __tcf_action_put() that releases reference to action and >frees it, if necessary. Refactor action deletion code to use new put >function and not to rely on rtnl lock. Remove rtnl lock assertions that are >no longer needed. > >Signed-off-by: Vlad Buslov Signed-off-by: Jiri Pirko