From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 00/14] nfp: abm: RED/MQ qdisc offload Date: Tue, 29 May 2018 09:51:08 -0400 (EDT) Message-ID: <20180529.095108.1565765638395915319.davem@davemloft.net> References: <20180526045338.10993-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jiri@resnulli.us, xiyou.wangcong@gmail.com, john.fastabend@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com, alexei.starovoitov@gmail.com, nogahf@mellanox.com, yuvalm@mellanox.com, gerlitz.or@gmail.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:55248 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934101AbeE2NvL (ORCPT ); Tue, 29 May 2018 09:51:11 -0400 In-Reply-To: <20180526045338.10993-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Fri, 25 May 2018 21:53:24 -0700 > This is second batch of advanced buffer management nfp driver > changes. This series adds the qdisc offload. Support for > a very simple subset of RED qdisc offload is added as needed > for DCTCP ECN marking (min and max thresholds set to the same > value). > > The first two patches fix glitches introduced by the previous > series. We have to be careful about phys_port_name handling, > because VFs share the same code path, and some user space may > get confused by the names we chose. > > Since unlike previous offloads we can report the queue backlog > both in bytes and packets we need to adjust how statistics are > added up in the core (patch 6). > > There are some extra statistics we want to expose which don't > fit into TC stats, namely counts of packets which have been fast- > -forwarded without getting enqueued because there was no > contention and number of packets that were ever queued (sum of > all momentary backlogs). We expose those through ethtool stats > (patches 8 and 9). > > Remaining 5 patches add MQ offload - to be able to set different > configurations on different queues. Representors are made multi- > -queue and we add offload support to MQ. MQ stats are added up > before calling ->dump qdiscs on the children, and therefore don't > include updated offload values. To avoid clearly incorrect stats > MQ is made to also request stats update from offloads. This way > we can correct the diff at the driver level. Series applied, thanks Jakub.