netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Michael Chan <michael.chan@broadcom.com>
Cc: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
	David Miller <davem@davemloft.net>,
	Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.
Date: Wed, 30 May 2018 15:36:07 -0700	[thread overview]
Message-ID: <20180530153607.3f09d765@cakuba> (raw)
In-Reply-To: <CACKFLi=-QVePYwAiG+boXoH0tdWTaM1ZRyV4qxsj0Au1w5PKBQ@mail.gmail.com>

On Wed, 30 May 2018 00:18:39 -0700, Michael Chan wrote:
> On Tue, May 29, 2018 at 11:33 PM, Jakub Kicinski wrote:
> > At some points you (Broadcom) were working whole bunch of devlink
> > configuration options for the PCIe side of the ASIC.  The number of
> > queues relates to things like number of allocated MSI-X vectors, which
> > if memory serves me was in your devlink patch set.  In an ideal world
> > we would try to keep all those in one place :)  
> 
> Yeah, another colleague is now working with Mellanox on something similar.
> 
> One difference between those devlink parameters and these queue
> parameters is that the former are more permanent and global settings.
> For example, number of VFs or number of MSIX per VF are persistent
> settings once they are set and after PCIe reset.  On the other hand,
> these queue settings are pure run-time settings and may be unique for
> each VF.  These are not stored as there is no room in NVRAM to store
> 128 sets or more of these parameters.

Indeed, I think the API must be flexible as to what is persistent and
what is not because HW will certainly differ in that regard.  And
agreed, queues may be a bit of a stretch here, but worth a try.

> Anyway, let me discuss this with my colleague to see if there is a
> natural fit for these queue parameters in the devlink infrastructure
> that they are working on.

Thank you!

  reply	other threads:[~2018-05-30 22:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29  8:18 [PATCH net-next 0/3] net: Add support to configure SR-IOV VF queues Michael Chan
2018-05-29  8:18 ` [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues Michael Chan
2018-05-29 20:46   ` Samudrala, Sridhar
2018-05-30  3:19     ` Michael Chan
2018-05-30 22:36       ` Jakub Kicinski [this message]
2018-05-29  8:18 ` [PATCH net-next 2/3] bnxt_en: Store min/max tx/rx rings for individual VFs Michael Chan
2018-05-29  8:18 ` [PATCH net-next 3/3] bnxt_en: Implement .ndo_set_vf_queues() Michael Chan
  -- strict thread matches above, loose matches on Subject: below --
2018-05-30  5:56 [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues Jakub Kicinski
2018-05-30  6:08 ` Michael Chan
2018-05-30  6:33   ` Jakub Kicinski
2018-05-30  7:18     ` Michael Chan
2018-05-30 21:23     ` Samudrala, Sridhar
2018-05-30 22:53       ` Jakub Kicinski
2018-05-31  3:35         ` Samudrala, Sridhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530153607.3f09d765@cakuba \
    --to=jakub.kicinski@netronome.com \
    --cc=davem@davemloft.net \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=sridhar.samudrala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).