From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo Date: Wed, 30 May 2018 19:15:29 +0200 Message-ID: <20180530191529.5af25d0a@redhat.com> References: <20180528004344.3606-1-daniel@iogearbox.net> <20180528004344.3606-5-daniel@iogearbox.net> <20180529192758.28240588@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Daniel Borkmann , Networking , brouer@redhat.com To: Song Liu Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49250 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753592AbeE3RPg (ORCPT ); Wed, 30 May 2018 13:15:36 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 30 May 2018 09:15:25 -0700 Song Liu wrote: > On Tue, May 29, 2018 at 12:55 PM, Daniel Borkmann wrote: > > On 05/29/2018 07:27 PM, Jesper Dangaard Brouer wrote: > >> On Mon, 28 May 2018 02:43:37 +0200 > >> Daniel Borkmann wrote: > >> > >>> Its trivial and straight forward to expose it for scripts that can > >>> then use it along with bpftool in order to inspect an individual > >>> application's used maps and progs. Right now we dump some basic > >>> information in the fdinfo file but with the help of the map/prog > >>> id full introspection becomes possible now. > >>> > >>> Signed-off-by: Daniel Borkmann > >>> Acked-by: Alexei Starovoitov > > Acked-by: Song Liu > > >> > >> AFAICR iproute uses this proc fdinfo, for pinned maps. Have you tested > >> if this change is handled gracefully by tc ? > > > > Yep, it works just fine, I also tested it before submission. Sounds good. Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer