From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH v3 11/11] net: sched: change action API to use array of pointers to actions Date: Wed, 30 May 2018 22:37:22 +0200 Message-ID: <20180530203722.GH2010@nanopsycho> References: <20180527175739.GA3337@nanopsycho> <1527455849-22327-1-git-send-email-vladbu@mellanox.com> <1527455849-22327-12-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, kliteyn@mellanox.com To: Vlad Buslov Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:34156 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932307AbeE3Uht (ORCPT ); Wed, 30 May 2018 16:37:49 -0400 Received: by mail-pf0-f195.google.com with SMTP id a14-v6so9603426pfi.1 for ; Wed, 30 May 2018 13:37:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1527455849-22327-12-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: Sun, May 27, 2018 at 11:17:29PM CEST, vladbu@mellanox.com wrote: >Act API used linked list to pass set of actions to functions. It is >intrusive data structure that stores list nodes inside action structure >itself, which means it is not safe to modify such list concurrently. >However, action API doesn't use any linked list specific operations on this >set of actions, so it can be safely refactored into plain pointer array. > >Refactor action API to use array of pointers to tc_actions instead of >linked list. Change argument 'actions' type of exported action init, >destroy and dump functions. > >Signed-off-by: Vlad Buslov Even with the nit Marcelo found, this looks fine to me. Acked-by: Jiri Pirko