From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v4 0/8] net: bridge: Notify about bridge VLANs Date: Thu, 31 May 2018 14:14:12 -0400 (EDT) Message-ID: <20180531.141412.1289727831618161534.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, bridge@lists.linux-foundation.org, jiri@mellanox.com, idosch@mellanox.com, razvan.stefanescu@nxp.com, gregkh@linuxfoundation.org, stephen@networkplumber.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, nikolay@cumulusnetworks.com, dan.carpenter@oracle.com To: petrm@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:60918 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755824AbeEaSOP (ORCPT ); Thu, 31 May 2018 14:14:15 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Petr Machata Date: Wed, 30 May 2018 02:55:34 +0200 > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also influenced by PVID setting of said bridge. However, changes to VLAN > configuration of the bridge itself do not generate switchdev > notifications, so there's no mechanism to prod mlxsw to update the > offload when these settings change. > > In this patchset, the problem is resolved by distributing the switchdev > notification SWITCHDEV_OBJ_ID_PORT_VLAN also for configuration changes > on bridge VLANs. Since stacked devices distribute the notification to > lower devices, such event eventually reaches the driver, which can > determine whether it's a bridge or port VLAN by inspecting orig_dev. > > To keep things consistent, the newly-distributed notifications observe > the same protocol as the existing ones: dual prepare/commit, with > -EOPNOTSUPP indicating lack of support, even though there's currently > nothing to prepare for and nothing to support. Correspondingly, all > switchdev drivers have been updated to return -EOPNOTSUPP for bridge > VLAN notifications. > > In patches #1 and #2, the code base is changed to support the following > additions: functions br_switchdev_port_vlan_add() and > br_switchdev_port_vlan_del() are introduced to simplify sending > notifications; and br_vlan_add_existing() is introduced to later make it > simpler to add error-handling code for the case of configuring a > preexisting VLAN on bridge CPU port. > > In patches #3-#6, respectively for mlxsw, rocker, DSA and DPAA2 ethsw, > the new notifications (which are not enabled yet) are ignored to > maintain the current behavior. > > In patch #7, the notification is actually enabled. > > In patch #8, mlxsw is changed to update offloads of mirror-to-gre also > for bridge-related notifications. ... Series applied, thanks.