From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net/ncsi: Fix array size in dumpit handler Date: Thu, 31 May 2018 15:59:30 -0400 (EDT) Message-ID: <20180531.155930.1197591227145779002.davem@davemloft.net> References: <20180531041004.20172-1-sam@mendozajonas.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org To: sam@mendozajonas.com Return-path: In-Reply-To: <20180531041004.20172-1-sam@mendozajonas.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Samuel Mendoza-Jonas Date: Thu, 31 May 2018 14:10:04 +1000 > With CONFIG_CC_STACKPROTECTOR enabled the kernel panics as below when > parsing a NCSI_CMD_PKG_INFO command: ... > This turns out to be because the attrs array in ncsi_pkg_info_all_nl() > is initialised to a length of NCSI_ATTR_MAX which is the maximum > attribute number, not the number of attributes. > > Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family") > Signed-off-by: Samuel Mendoza-Jonas Applied, thanks.