Netdev List
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Colin King <colin.king@canonical.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
Date: Thu, 31 May 2018 10:05:18 +0300	[thread overview]
Message-ID: <20180531070518.obnfw5tv23sbpfys@mwanda> (raw)
In-Reply-To: <20180530210713.v4cf4wjniwyobfmm@ast-mbp.dhcp.thefacebook.com>

On Wed, May 30, 2018 at 05:07:15PM -0400, Alexei Starovoitov wrote:
> On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The assignment dev = dev is redundant and should be removed.
> > 
> > Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Applied, Thanks.
> 
> Please use [PATCH bpf-next] in the subject next time.
> See Documentation/bpf/bpf_devel_QA.rst

Guys, be reasonable...

git log --author=Carpenter | \
	grep -A1 "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>" | \
	grep -v Carpenter | grep Signed | cut -d '<' -f 1 | sort -u | wc -l

I have sent patches to 206 maintainers.  It doesn't scale for everyone
to have their own special document for sending patches.

I asked this last time, and I even skimmed your document, but how are
people supposed to go from linux-next to the correct bpf-next git tree?
It's a pain for me to do this for net, but net is way larger and busier
than any other tree.  I know it's a bit rude for me to say that you guys
are not as important as net, but that's how I feel.  I'm only going to
report bugs instead of writing patches if you guys are going to insist
on all sorts of new rules.

regards,
dan carpenter

  reply	other threads:[~2018-05-31  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 15:09 [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev Colin King
2018-05-30 17:18 ` Song Liu
2018-05-30 21:07 ` Alexei Starovoitov
2018-05-31  7:05   ` Dan Carpenter [this message]
2018-05-31  8:14     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180531070518.obnfw5tv23sbpfys@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=daniel@iogearbox.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox