From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Date: Thu, 31 May 2018 08:58:12 -0400 Message-ID: <20180531085812.0b13afef@shemminger-XPS-13-9360> References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com> <1527180917-39737-3-git-send-email-sridhar.samudrala@intel.com> <20180530220635.206ee6d7@shemminger-XPS-13-9360> <274f0b84-07f1-5cd5-e256-ce4b71358c14@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: mst@redhat.com, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com, anjali.singhai@intel.com To: "Samudrala, Sridhar" Return-path: Received: from mail-qt0-f196.google.com ([209.85.216.196]:43494 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754820AbeEaM6U (ORCPT ); Thu, 31 May 2018 08:58:20 -0400 Received: by mail-qt0-f196.google.com with SMTP id y89-v6so2239943qtd.10 for ; Thu, 31 May 2018 05:58:20 -0700 (PDT) In-Reply-To: <274f0b84-07f1-5cd5-e256-ce4b71358c14@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 30 May 2018 20:03:11 -0700 "Samudrala, Sridhar" wrote: > On 5/30/2018 7:06 PM, Stephen Hemminger wrote: > > On Thu, 24 May 2018 09:55:14 -0700 > > Sridhar Samudrala wrote: > > > >> Use the registration/notification framework supported by the generic > >> failover infrastructure. > >> > >> Signed-off-by: Sridhar Samudrala > > Why was this merged? It was never signed off by any of the netvsc maintainers, > > and there were still issues unresolved. > > > > There are also namespaces issues I am fixing and this breaks them. > > Will start my patch set with a revert for this. Sorry > > I would appreciate if you can make the fixes on top of this patch series. I tried hard > to make sure that netvsc functionality and behavior doesn't change. > > It is possible that there could be some bugs introduced, but they can be fixed. > Looks like Wei already found a bug and submitted a fix for that. > Ok, but several of these may clash with what you want for virtio. Like: - VF should be moved to namespace of virt device - VF should be associated based on message from host with serial # not registration notifier and MAC address. - control operations should use master device reference rather than searching based on MAC. As you can see these are structural changes.