From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: Networking <netdev@vger.kernel.org>,
Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
John Fastabend <john.fastabend@gmail.com>,
makita.toshiaki@lab.ntt.co.jp, brouer@redhat.com
Subject: Re: [bpf-next V1 PATCH 0/8] bpf/xdp: add flags argument to ndo_xdp_xmit and flag flush operation
Date: Thu, 31 May 2018 09:39:16 +0200 [thread overview]
Message-ID: <20180531093916.78404201@redhat.com> (raw)
In-Reply-To: <CAPhsuW4kVDb4sk8UGOFx4cac5X7bBG_MTzSDsDzJLThcwAsnpQ@mail.gmail.com>
On Wed, 30 May 2018 15:18:02 -0700
Song Liu <liu.song.a23@gmail.com> wrote:
> Overall, this set looks good to me. The only suggestion I have is to add more
> documentation on the expected behavior of XDP_XMIT_FLUSH in netdevice.h
> (as part of 01/08).
I do see your point, as the behavior of XDP_XMIT_FLUSH is actually more
a "doorbell" functionality. I still choose to call it "flush", because
it is replacing a function called ndo_xdp_flush, and providing the
exact same code-function as ndo_xdp_flush. (IMHO it should have been
called ndo_xdo_doorbell).
Any opinions about renaming XDP_XMIT_FLUSH to XDP_XMIT_DOORBELL?
If you look at virtio_net and tun usage, the effect is a wakeup
(virtqueue_kick and sk_data_ready). Still I like the name "doorbell"
better than "wakeup", as it also maps to NIC usage which often call
this "doorbell" or "tail" pointer update.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
prev parent reply other threads:[~2018-05-31 7:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 18:00 [bpf-next V1 PATCH 0/8] bpf/xdp: add flags argument to ndo_xdp_xmit and flag flush operation Jesper Dangaard Brouer
2018-05-30 18:00 ` [bpf-next V1 PATCH 1/8] xdp: add flags argument to ndo_xdp_xmit API Jesper Dangaard Brouer
2018-05-30 21:55 ` Song Liu
2018-05-30 18:00 ` [bpf-next V1 PATCH 2/8] i40e: implement flush flag for ndo_xdp_xmit Jesper Dangaard Brouer
2018-05-30 21:58 ` Song Liu
2018-05-31 8:40 ` Jesper Dangaard Brouer
2018-05-31 8:47 ` Jesper Dangaard Brouer
2018-05-30 18:00 ` [bpf-next V1 PATCH 3/8] ixgbe: " Jesper Dangaard Brouer
2018-05-30 18:00 ` [bpf-next V1 PATCH 4/8] tun: " Jesper Dangaard Brouer
2018-05-30 18:00 ` [bpf-next V1 PATCH 5/8] virtio_net: " Jesper Dangaard Brouer
2018-05-30 18:01 ` [bpf-next V1 PATCH 6/8] xdp: done implementing ndo_xdp_xmit flush flag for all drivers Jesper Dangaard Brouer
2018-05-30 18:01 ` [bpf-next V1 PATCH 7/8] bpf/xdp: non-map redirect can avoid calling ndo_xdp_flush Jesper Dangaard Brouer
2018-05-30 18:01 ` [bpf-next V1 PATCH 8/8] bpf/xdp: devmap " Jesper Dangaard Brouer
2018-05-30 22:06 ` Song Liu
2018-05-31 7:49 ` Jesper Dangaard Brouer
2018-05-30 22:18 ` [bpf-next V1 PATCH 0/8] bpf/xdp: add flags argument to ndo_xdp_xmit and flag flush operation Song Liu
2018-05-31 7:39 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531093916.78404201@redhat.com \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=liu.song.a23@gmail.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).