From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH net-next] netfilter: nf_tables: check msg_type before nft_trans_set(trans) Date: Thu, 31 May 2018 21:07:31 +0200 Message-ID: <20180531190731.rrwayqgnnnd2fasn@breakpoint.cc> References: <1527785613-32005-1-git-send-email-alexey.kodanev@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , coreteam@netfilter.org, netdev To: Alexey Kodanev Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:50412 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021AbeEaTHe (ORCPT ); Thu, 31 May 2018 15:07:34 -0400 Content-Disposition: inline In-Reply-To: <1527785613-32005-1-git-send-email-alexey.kodanev@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: Alexey Kodanev wrote: > The patch moves the "trans->msg_type == NFT_MSG_NEWSET" check before > using nft_trans_set(trans). Otherwise we can get out of bounds read. Indeed, thanks for fixining this. Acked-by: Florian Westphal