From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Date: Thu, 31 May 2018 20:34:03 +0300 Message-ID: <20180531203301-mutt-send-email-mst@kernel.org> References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com> <1527180917-39737-3-git-send-email-sridhar.samudrala@intel.com> <20180530220635.206ee6d7@shemminger-XPS-13-9360> <274f0b84-07f1-5cd5-e256-ce4b71358c14@intel.com> <20180531085812.0b13afef@shemminger-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Samudrala, Sridhar" , davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com, anjali.singhai@intel.com To: Stephen Hemminger Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755824AbeEaReF (ORCPT ); Thu, 31 May 2018 13:34:05 -0400 Content-Disposition: inline In-Reply-To: <20180531085812.0b13afef@shemminger-XPS-13-9360> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, May 31, 2018 at 08:58:12AM -0400, Stephen Hemminger wrote: > On Wed, 30 May 2018 20:03:11 -0700 > "Samudrala, Sridhar" wrote: > > > On 5/30/2018 7:06 PM, Stephen Hemminger wrote: > > > On Thu, 24 May 2018 09:55:14 -0700 > > > Sridhar Samudrala wrote: > > > > > >> Use the registration/notification framework supported by the generic > > >> failover infrastructure. > > >> > > >> Signed-off-by: Sridhar Samudrala > > > Why was this merged? It was never signed off by any of the netvsc maintainers, > > > and there were still issues unresolved. > > > > > > There are also namespaces issues I am fixing and this breaks them. > > > Will start my patch set with a revert for this. Sorry > > > > I would appreciate if you can make the fixes on top of this patch series. I tried hard > > to make sure that netvsc functionality and behavior doesn't change. > > > > It is possible that there could be some bugs introduced, but they can be fixed. > > Looks like Wei already found a bug and submitted a fix for that. > > > > Ok, but several of these may clash with what you want for virtio. > Like: > - VF should be moved to namespace of virt device > - VF should be associated based on message from host with serial # not > registration notifier and MAC address. > - control operations should use master device reference rather than > searching based on MAC. > > As you can see these are structural changes. We might want to do these for virtio as well, at least as an option. -- MST