* [PATCH net-next] virtio_net: fix error return code in virtnet_probe()
@ 2018-05-31 2:05 Wei Yongjun
2018-05-31 2:05 ` Jason Wang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yongjun @ 2018-05-31 2:05 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Sridhar Samudrala
Cc: Wei Yongjun, virtualization, netdev, kernel-janitors
Fix to return a negative error code from the failover create fail error
handling case instead of 0, as done elsewhere in this function.
Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/virtio_net.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 8f08a3e..2d55e2a 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2935,8 +2935,10 @@ static int virtnet_probe(struct virtio_device *vdev)
if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) {
vi->failover = net_failover_create(vi->dev);
- if (IS_ERR(vi->failover))
+ if (IS_ERR(vi->failover)) {
+ err = PTR_ERR(vi->failover);
goto free_vqs;
+ }
}
err = register_netdev(dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] virtio_net: fix error return code in virtnet_probe()
2018-05-31 2:05 [PATCH net-next] virtio_net: fix error return code in virtnet_probe() Wei Yongjun
@ 2018-05-31 2:05 ` Jason Wang
2018-05-31 17:37 ` Michael S. Tsirkin
2018-06-01 2:50 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2018-05-31 2:05 UTC (permalink / raw)
To: Wei Yongjun, Michael S. Tsirkin, Sridhar Samudrala
Cc: virtualization, netdev, kernel-janitors
On 2018年05月31日 10:05, Wei Yongjun wrote:
> Fix to return a negative error code from the failover create fail error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/virtio_net.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 8f08a3e..2d55e2a 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2935,8 +2935,10 @@ static int virtnet_probe(struct virtio_device *vdev)
>
> if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) {
> vi->failover = net_failover_create(vi->dev);
> - if (IS_ERR(vi->failover))
> + if (IS_ERR(vi->failover)) {
> + err = PTR_ERR(vi->failover);
> goto free_vqs;
> + }
> }
>
> err = register_netdev(dev);
>
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] virtio_net: fix error return code in virtnet_probe()
2018-05-31 2:05 [PATCH net-next] virtio_net: fix error return code in virtnet_probe() Wei Yongjun
2018-05-31 2:05 ` Jason Wang
@ 2018-05-31 17:37 ` Michael S. Tsirkin
2018-06-01 2:50 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2018-05-31 17:37 UTC (permalink / raw)
To: Wei Yongjun
Cc: Jason Wang, Sridhar Samudrala, virtualization, netdev,
kernel-janitors
On Thu, May 31, 2018 at 02:05:07AM +0000, Wei Yongjun wrote:
> Fix to return a negative error code from the failover create fail error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 8f08a3e..2d55e2a 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2935,8 +2935,10 @@ static int virtnet_probe(struct virtio_device *vdev)
>
> if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) {
> vi->failover = net_failover_create(vi->dev);
> - if (IS_ERR(vi->failover))
> + if (IS_ERR(vi->failover)) {
> + err = PTR_ERR(vi->failover);
> goto free_vqs;
> + }
> }
>
> err = register_netdev(dev);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] virtio_net: fix error return code in virtnet_probe()
2018-05-31 2:05 [PATCH net-next] virtio_net: fix error return code in virtnet_probe() Wei Yongjun
2018-05-31 2:05 ` Jason Wang
2018-05-31 17:37 ` Michael S. Tsirkin
@ 2018-06-01 2:50 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-06-01 2:50 UTC (permalink / raw)
To: weiyongjun1
Cc: mst, jasowang, sridhar.samudrala, virtualization, netdev,
kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Thu, 31 May 2018 02:05:07 +0000
> Fix to return a negative error code from the failover create fail error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-01 2:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-31 2:05 [PATCH net-next] virtio_net: fix error return code in virtnet_probe() Wei Yongjun
2018-05-31 2:05 ` Jason Wang
2018-05-31 17:37 ` Michael S. Tsirkin
2018-06-01 2:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).