From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Date: Thu, 31 May 2018 21:35:59 +0300 Message-ID: <20180531212356-mutt-send-email-mst@kernel.org> References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com> <1527180917-39737-3-git-send-email-sridhar.samudrala@intel.com> <20180530220635.206ee6d7@shemminger-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sridhar Samudrala , davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com, anjali.singhai@intel.com To: Stephen Hemminger Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40602 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755879AbeEaSgB (ORCPT ); Thu, 31 May 2018 14:36:01 -0400 Content-Disposition: inline In-Reply-To: <20180530220635.206ee6d7@shemminger-XPS-13-9360> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, May 30, 2018 at 10:06:35PM -0400, Stephen Hemminger wrote: > On Thu, 24 May 2018 09:55:14 -0700 > Sridhar Samudrala wrote: > > > Use the registration/notification framework supported by the generic > > failover infrastructure. > > > > Signed-off-by: Sridhar Samudrala > > Why was this merged? It was never signed off by any of the netvsc maintainers, > and there were still issues unresolved. > > There are also namespaces issues I am fixing and this breaks them. > Will start my patch set with a revert for this. Sorry As long as you finish the patch set with re-integrating with failover, that's fine IMHO. I suspect it's easier to add the code to failover though - namespace things likely affect virtio as well. Lookup by ID would be an optional feature for virtio, but probably a useful one - I won't ask you to add it to virtio but it could be a mode in failover that virtio will activate down the road. And reducing the number of times we look cards up based on ID can only be a good thing. -- MST