From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH net-next] netfilter: nf_tables: check msg_type before
 nft_trans_set(trans)
Date: Fri, 1 Jun 2018 10:14:11 +0200
Message-ID: <20180601081411.sk4py3rkduckmiyg@salvia>
References: <1527785613-32005-1-git-send-email-alexey.kodanev@oracle.com>
 <20180531190731.rrwayqgnnnd2fasn@breakpoint.cc>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alexey Kodanev <alexey.kodanev@oracle.com>,
        netfilter-devel@vger.kernel.org,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        coreteam@netfilter.org, netdev <netdev@vger.kernel.org>
To: Florian Westphal <fw@strlen.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.us.es ([193.147.175.20]:43176 "EHLO mail.us.es"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750861AbeFAIOP (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 1 Jun 2018 04:14:15 -0400
Received: from antivirus1-rhel7.int (unknown [192.168.2.11])
        by mail.us.es (Postfix) with ESMTP id C50CFC1271
        for <netdev@vger.kernel.org>; Fri,  1 Jun 2018 10:13:03 +0200 (CEST)
Received: from antivirus1-rhel7.int (localhost [127.0.0.1])
        by antivirus1-rhel7.int (Postfix) with ESMTP id B3AD1DA4D3
        for <netdev@vger.kernel.org>; Fri,  1 Jun 2018 10:13:03 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180531190731.rrwayqgnnnd2fasn@breakpoint.cc>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, May 31, 2018 at 09:07:31PM +0200, Florian Westphal wrote:
> Alexey Kodanev <alexey.kodanev@oracle.com> wrote:
> > The patch moves the "trans->msg_type == NFT_MSG_NEWSET" check before
> > using nft_trans_set(trans). Otherwise we can get out of bounds read.
> 
> Indeed, thanks for fixining this.
> 
> Acked-by: Florian Westphal <fw@strlen.de>

Also applied to nf.git, thanks!