From: Stephen Hemminger <stephen@networkplumber.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support
Date: Fri, 1 Jun 2018 16:02:30 -0400 [thread overview]
Message-ID: <20180601160230.1708226c@shemminger-XPS-13-9360> (raw)
In-Reply-To: <b20932cf-3426-8c82-8496-cdae1738a4fe@6wind.com>
On Fri, 1 Jun 2018 17:02:18 +0200
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> Le 31/05/2018 à 17:51, Nicolas Dichtel a écrit :
> > Le 31/05/2018 à 17:46, Stephen Hemminger a écrit :
> >> On Thu, 31 May 2018 16:28:48 +0200
> > [snip]
> >> This makes sense. All of linkinfo that is present should be displayed.
> >>
> >> Both netns and ifindex are really unsigned values. Use __u32 and print_uint.
> > Ok.
> I replied a bit quickly, both are signed values:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/core/rtnetlink.c#n1621
>
>
> Regards,
> Nicolas
Ok, Applied orignal patch
next prev parent reply other threads:[~2018-06-01 20:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 14:28 [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support Nicolas Dichtel
2018-05-31 14:31 ` Nicolas Dichtel
2018-05-31 15:46 ` Stephen Hemminger
2018-05-31 15:51 ` Nicolas Dichtel
2018-06-01 15:02 ` Nicolas Dichtel
2018-06-01 20:02 ` Stephen Hemminger [this message]
2018-06-04 12:12 ` [PATCH iproute2 0/2] display netns name instead of nsid Nicolas Dichtel
2018-06-04 12:12 ` [PATCH iproute2 1/2] ip: " Nicolas Dichtel
2018-06-04 21:12 ` Stephen Hemminger
2018-06-05 13:08 ` [PATCH iproute2 v2 0/2] " Nicolas Dichtel
2018-06-05 13:08 ` [PATCH iproute2 v2 1/2] ip: " Nicolas Dichtel
2018-06-05 16:52 ` Stephen Hemminger
2018-06-06 7:11 ` Nicolas Dichtel
2018-06-05 13:08 ` [PATCH iproute2 v2 2/2] iplink: enable to specify a name for the link-netns Nicolas Dichtel
2018-06-08 17:08 ` [PATCH iproute2 v2 0/2] display netns name instead of nsid Stephen Hemminger
2018-06-04 12:12 ` [PATCH iproute2 2/2] iplink: enable to specify a name for the link-netns Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601160230.1708226c@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox