From: Salil Mehta <salil.mehta@huawei.com>
To: <davem@davemloft.net>
Cc: <salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<lipeng321@huawei.com>, <mehta.salil@opnsrc.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, Jian Shen <shenjian15@huawei.com>
Subject: [PATCH net-next 03/11] net: hns3: Add repeat address checking for setting mac address
Date: Fri, 1 Jun 2018 17:52:03 +0100 [thread overview]
Message-ID: <20180601165211.46372-4-salil.mehta@huawei.com> (raw)
In-Reply-To: <20180601165211.46372-1-salil.mehta@huawei.com>
From: Jian Shen <shenjian15@huawei.com>
Add checking for new mac address. It doesn't need to config
the mac vlan table if it's already in use.
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 0a6876a..fe54564 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -1132,6 +1132,12 @@ static int hns3_nic_net_set_mac_address(struct net_device *netdev, void *p)
if (!mac_addr || !is_valid_ether_addr((const u8 *)mac_addr->sa_data))
return -EADDRNOTAVAIL;
+ if (ether_addr_equal(netdev->dev_addr, mac_addr->sa_data)) {
+ netdev_info(netdev, "already using mac address %pM\n",
+ mac_addr->sa_data);
+ return 0;
+ }
+
ret = h->ae_algo->ops->set_mac_addr(h, mac_addr->sa_data, false);
if (ret) {
netdev_err(netdev, "set_mac_address fail, ret=%d!\n", ret);
--
2.7.4
next prev parent reply other threads:[~2018-06-01 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:52 [PATCH net-next 00/11] Misc. bug fixes & optimizations for HNS3 driver Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 01/11] net: hns3: Disable vf vlan filter when vf vlan table is full Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 02/11] net: hns3: Add support for IFF_ALLMULTI flag Salil Mehta
2018-06-01 16:52 ` Salil Mehta [this message]
2018-06-01 16:52 ` [PATCH net-next 04/11] net: hns3: Fix setting mac address error Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 05/11] net: hns3: Fix for service_task not running problem after resetting Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 06/11] net: hns3: Fix for hclge_reset running repeatly problem Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 07/11] net: hns3: Fix for phy not link up problem after resetting Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 08/11] net: hns3: Add missing break in misc_irq_handle Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 09/11] net: hns3: Fix for vxlan tx checksum bug Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 10/11] net: hns3: Optimize the PF's process of updating multicast MAC Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 11/11] net: hns3: Optimize the VF's " Salil Mehta
2018-06-01 18:24 ` [PATCH net-next 00/11] Misc. bug fixes & optimizations for HNS3 driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601165211.46372-4-salil.mehta@huawei.com \
--to=salil.mehta@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil@opnsrc.net \
--cc=netdev@vger.kernel.org \
--cc=shenjian15@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).