From: Salil Mehta <salil.mehta@huawei.com>
To: <davem@davemloft.net>
Cc: <salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<lipeng321@huawei.com>, <mehta.salil@opnsrc.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, Jian Shen <shenjian15@huawei.com>
Subject: [PATCH net-next 04/11] net: hns3: Fix setting mac address error
Date: Fri, 1 Jun 2018 17:52:04 +0100 [thread overview]
Message-ID: <20180601165211.46372-5-salil.mehta@huawei.com> (raw)
In-Reply-To: <20180601165211.46372-1-salil.mehta@huawei.com>
From: Jian Shen <shenjian15@huawei.com>
When doing function reset or insmod hns3 dirver after rmmod,
the entries of mac vlan table are not cleared, which may cause
init mac address failed. This patch fixes it by clearing the
old mac address when doing function reset or rmmod hns3 driver.
Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index fe54564..235eea1 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -3007,6 +3007,15 @@ static void hns3_init_mac_addr(struct net_device *netdev, bool init)
}
+static void hns3_uninit_mac_addr(struct net_device *netdev)
+{
+ struct hns3_nic_priv *priv = netdev_priv(netdev);
+ struct hnae3_handle *h = priv->ae_handle;
+
+ if (h->ae_algo->ops->rm_uc_addr)
+ h->ae_algo->ops->rm_uc_addr(h, netdev->dev_addr);
+}
+
static void hns3_nic_set_priv_ops(struct net_device *netdev)
{
struct hns3_nic_priv *priv = netdev_priv(netdev);
@@ -3135,6 +3144,8 @@ static void hns3_client_uninit(struct hnae3_handle *handle, bool reset)
priv->ring_data = NULL;
+ hns3_uninit_mac_addr(netdev);
+
free_netdev(netdev);
}
@@ -3451,6 +3462,8 @@ static int hns3_reset_notify_uninit_enet(struct hnae3_handle *handle)
priv->ring_data = NULL;
+ hns3_uninit_mac_addr(netdev);
+
return ret;
}
--
2.7.4
next prev parent reply other threads:[~2018-06-01 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:52 [PATCH net-next 00/11] Misc. bug fixes & optimizations for HNS3 driver Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 01/11] net: hns3: Disable vf vlan filter when vf vlan table is full Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 02/11] net: hns3: Add support for IFF_ALLMULTI flag Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 03/11] net: hns3: Add repeat address checking for setting mac address Salil Mehta
2018-06-01 16:52 ` Salil Mehta [this message]
2018-06-01 16:52 ` [PATCH net-next 05/11] net: hns3: Fix for service_task not running problem after resetting Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 06/11] net: hns3: Fix for hclge_reset running repeatly problem Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 07/11] net: hns3: Fix for phy not link up problem after resetting Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 08/11] net: hns3: Add missing break in misc_irq_handle Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 09/11] net: hns3: Fix for vxlan tx checksum bug Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 10/11] net: hns3: Optimize the PF's process of updating multicast MAC Salil Mehta
2018-06-01 16:52 ` [PATCH net-next 11/11] net: hns3: Optimize the VF's " Salil Mehta
2018-06-01 18:24 ` [PATCH net-next 00/11] Misc. bug fixes & optimizations for HNS3 driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601165211.46372-5-salil.mehta@huawei.com \
--to=salil.mehta@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil@opnsrc.net \
--cc=netdev@vger.kernel.org \
--cc=shenjian15@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).