From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf-next v3 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps Date: Sun, 3 Jun 2018 08:56:51 +0200 Message-ID: <20180603085651.73c76704@redhat.com> References: <20180602210641.6163-1-daniel@iogearbox.net> <20180602210641.6163-6-daniel@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: brouer@redhat.com, alexei.starovoitov@gmail.com, netdev@vger.kernel.org To: Daniel Borkmann Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50300 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750814AbeFCG45 (ORCPT ); Sun, 3 Jun 2018 02:56:57 -0400 In-Reply-To: <20180602210641.6163-6-daniel@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 2 Jun 2018 23:06:35 +0200 Daniel Borkmann wrote: > Before: > > # bpftool p d x i 1 Could this please be changed to: # bpftool prog dump xlated id 1 I requested this before, but you seem to have missed my feedback... This makes the command "self-documenting" and searchable by Google. > 0: (bf) r2 = r10 > 1: (07) r2 += -8 > 2: (7a) *(u64 *)(r2 +0) = 0 > 3: (18) r1 = map[id:1] > 5: (85) call __htab_map_lookup_elem#232656 > 6: (15) if r0 == 0x0 goto pc+4 > 7: (71) r1 = *(u8 *)(r0 +35) > 8: (55) if r1 != 0x0 goto pc+1 > 9: (72) *(u8 *)(r0 +35) = 1 > 10: (07) r0 += 56 > 11: (15) if r0 == 0x0 goto pc+4 > 12: (bf) r2 = r0 > 13: (18) r1 = map[id:1] > 15: (85) call bpf_map_delete_elem#215008 <-- indirect call via > 16: (95) exit helper > -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer