From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: aquantia: make function aq_fw2x_get_mac_permanent static Date: Mon, 04 Jun 2018 11:31:29 -0400 (EDT) Message-ID: <20180604.113129.2259414741108607335.davem@davemloft.net> References: <20180601152834.17958-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: igor.russkikh@aquantia.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20180601152834.17958-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Fri, 1 Jun 2018 16:28:34 +0100 > From: Colin Ian King > > The function aq_fw2x_get_mac_permanent is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > warning: symbol 'aq_fw2x_get_mac_permanent' was not declared. Should it > be static? > > Signed-off-by: Colin Ian King Applied to net-next, thank you.