From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO Date: Mon, 04 Jun 2018 15:41:14 -0400 (EDT) Message-ID: <20180604.154114.1354490403993234203.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:51638 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751151AbeFDTlQ (ORCPT ); Mon, 4 Jun 2018 15:41:16 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Sat, 2 Jun 2018 22:33:36 +0200 > Current implementation of MDIO bus PM ops doesn't actually implement > bus-specific PM ops but just calls PM ops defined on a device level > what doesn't seem to be fully in line with the core PM model. > > When looking e.g. at __device_suspend() the PM core looks for PM ops > of a device in a specific order: > 1. device PM domain > 2. device type > 3. device class > 4. device bus > > I think it has good reason that there's no PM ops on device level. > The situation can be improved by modeling PHY's as device type of > a MDIO device. If for some other type of MDIO device PM ops are > needed, it could be modeled as struct device_type as well. Andrew and Florian, it would nice if one of you would review this patch series. Thank you.