From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: qualcomm: rmnet: Fix use after free while sending command ack Date: Mon, 04 Jun 2018 17:16:36 -0400 (EDT) Message-ID: <20180604.171636.2093719716731598906.davem@davemloft.net> References: <1528064275-3205-1-git-send-email-subashab@codeaurora.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: subashab@codeaurora.org Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52690 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbeFDVQh (ORCPT ); Mon, 4 Jun 2018 17:16:37 -0400 In-Reply-To: <1528064275-3205-1-git-send-email-subashab@codeaurora.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Subash Abhinov Kasiviswanathan Date: Sun, 3 Jun 2018 16:17:55 -0600 > When sending an ack to a command packet, the skb is still referenced > after it is sent to the real device. Since the real device could > free the skb, the device pointer would be invalid. > > Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation") > Signed-off-by: Subash Abhinov Kasiviswanathan This doesn't apply cleanly to the current net-next tree, please respin.