From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/2 v2 net-next] net_failover: Use netdev_features_t instead of u32 Date: Mon, 04 Jun 2018 17:30:53 -0400 (EDT) Message-ID: <20180604.173053.1467861125387241500.davem@davemloft.net> References: <20180604.093147.1707102168081704551.davem@davemloft.net> <20180604144321.kjemxdfhi4qqb5ji@kili.mountain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sridhar.samudrala@intel.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: dan.carpenter@oracle.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52906 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbeFDVaz (ORCPT ); Mon, 4 Jun 2018 17:30:55 -0400 In-Reply-To: <20180604144321.kjemxdfhi4qqb5ji@kili.mountain> Sender: netdev-owner@vger.kernel.org List-ID: From: Dan Carpenter Date: Mon, 4 Jun 2018 17:43:21 +0300 > The features mask needs to be a netdev_features_t (u64) because a u32 > is not big enough. > > Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") > Signed-off-by: Dan Carpenter > --- > v2: In the original patch, I thought that the & should be | and I > introduced a bug. Applied.