From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: sched: return error code when tcf proto is not found Date: Mon, 04 Jun 2018 17:32:19 -0400 (EDT) Message-ID: <20180604.173219.1997841279674931039.davem@davemloft.net> References: <1528126343-13104-1-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, dan.carpenter@oracle.com To: vladbu@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52950 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbeFDVcW (ORCPT ); Mon, 4 Jun 2018 17:32:22 -0400 In-Reply-To: <1528126343-13104-1-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vlad Buslov Date: Mon, 4 Jun 2018 18:32:23 +0300 > If requested tcf proto is not found, get and del filter netlink protocol > handlers output error message to extack, but do not return actual error > code. Add check to return ENOENT when result of tp find function is NULL > pointer. > > Fixes: c431f89b18a2 ("net: sched: split tc_ctl_tfilter into three > handlers") Please do not split up a Fixes: tag into multiple lines. I fixed it up for you this time. > Reported-by: Dan Carpenter > Signed-off-by: Vlad Buslov Applied, thanks.