From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH 1/2 v2 net-next] net_failover: Use netdev_features_t instead of u32 Date: Mon, 4 Jun 2018 17:43:21 +0300 Message-ID: <20180604144321.kjemxdfhi4qqb5ji@kili.mountain> References: <20180604.093147.1707102168081704551.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: "David S. Miller" , Sridhar Samudrala Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:44100 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753443AbeFDOnd (ORCPT ); Mon, 4 Jun 2018 10:43:33 -0400 Content-Disposition: inline In-Reply-To: <20180604.093147.1707102168081704551.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: The features mask needs to be a netdev_features_t (u64) because a u32 is not big enough. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: Dan Carpenter --- v2: In the original patch, I thought that the & should be | and I introduced a bug. diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index 8b508e2cf29b..83f7420ddea5 100644 --- a/drivers/net/net_failover.c +++ b/drivers/net/net_failover.c @@ -380,7 +380,8 @@ static rx_handler_result_t net_failover_handle_frame(struct sk_buff **pskb) static void net_failover_compute_features(struct net_device *dev) { - u32 vlan_features = FAILOVER_VLAN_FEATURES & NETIF_F_ALL_FOR_ALL; + netdev_features_t vlan_features = FAILOVER_VLAN_FEATURES & + NETIF_F_ALL_FOR_ALL; netdev_features_t enc_features = FAILOVER_ENC_FEATURES; unsigned short max_hard_header_len = ETH_HLEN; unsigned int dst_release_flag = IFF_XMIT_DST_RELEASE |