From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/2 net] team: use netdev_features_t instead of u32
Date: Mon, 4 Jun 2018 17:46:01 +0300 [thread overview]
Message-ID: <20180604144601.wo5iqb5irfes4frv@kili.mountain> (raw)
In-Reply-To: <20180604.093147.1707102168081704551.davem@davemloft.net>
This code was introduced in 2011 around the same time that we made
netdev_features_t a u64 type. These days a u32 is not big enough to
hold all the potential features.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 267dcc929f6c..8863fa023500 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1004,7 +1004,8 @@ static void team_port_disable(struct team *team,
static void __team_compute_features(struct team *team)
{
struct team_port *port;
- u32 vlan_features = TEAM_VLAN_FEATURES & NETIF_F_ALL_FOR_ALL;
+ netdev_features_t vlan_features = TEAM_VLAN_FEATURES &
+ NETIF_F_ALL_FOR_ALL;
netdev_features_t enc_features = TEAM_ENC_FEATURES;
unsigned short max_hard_header_len = ETH_HLEN;
unsigned int dst_release_flag = IFF_XMIT_DST_RELEASE |
next prev parent reply other threads:[~2018-06-04 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 12:01 [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features() Dan Carpenter
2018-05-31 17:30 ` Samudrala, Sridhar
2018-06-04 13:31 ` David Miller
2018-06-04 14:43 ` [PATCH 1/2 v2 net-next] net_failover: Use netdev_features_t instead of u32 Dan Carpenter
2018-06-04 21:30 ` David Miller
2018-06-04 14:46 ` Dan Carpenter [this message]
2018-06-04 14:49 ` [PATCH 2/2 net] team: use " Jiri Pirko
2018-06-04 21:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604144601.wo5iqb5irfes4frv@kili.mountain \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox