From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH net-next 2/3] netdevsim: Add extack error message for
 devlink reload
Date: Mon, 4 Jun 2018 15:47:12 -0700
Message-ID: <20180604154712.42aa1885@cakuba.netronome.com>
References: <20180604221503.20329-1-dsahern@kernel.org>
        <20180604221503.20329-3-dsahern@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com,
        David Ahern <dsahern@gmail.com>
To: dsahern@kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt0-f195.google.com ([209.85.216.195]:37187 "EHLO
        mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751000AbeFDWrS (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 4 Jun 2018 18:47:18 -0400
Received: by mail-qt0-f195.google.com with SMTP id q13-v6so424775qtp.4
        for <netdev@vger.kernel.org>; Mon, 04 Jun 2018 15:47:18 -0700 (PDT)
In-Reply-To: <20180604221503.20329-3-dsahern@kernel.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon,  4 Jun 2018 15:15:02 -0700, dsahern@kernel.org wrote:
> From: David Ahern <dsahern@gmail.com>
> 
> devlink reset command can fail if a FIB resource limit is set to a value
> lower than the current occupancy. Return a proper message indicating the
> reason for the failure.
> 
> $ devlink resource sh netdevsim/netdevsim0
> netdevsim/netdevsim0:
>   name IPv4 size unlimited unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>     resources:
>       name fib size unlimited occ 43 unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>       name fib-rules size unlimited occ 4 unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>   name IPv6 size unlimited unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>     resources:
>       name fib size unlimited occ 54 unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>       name fib-rules size unlimited occ 3 unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
> 
> $ devlink resource set netdevsim/netdevsim0 path /IPv4/fib size 40
> 
> $ devlink dev  reload netdevsim/netdevsim0
> Error: netdevsim: New size is less than current occupancy.
> devlink answers: Invalid argument
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

The entire set looks very useful, thanks!