From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old filter mask with new filter Date: Mon, 4 Jun 2018 19:52:03 +0200 Message-ID: <20180604175202.w3zxbkwdrqg3miuv@netronome.com> References: <1528009574-63306-1-git-send-email-paulb@mellanox.com> <1528009574-63306-2-git-send-email-paulb@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jiri Pirko , Cong Wang , Jamal Hadi Salim , David Miller , netdev@vger.kernel.org, Yevgeny Kliteynik , Roi Dayan , Shahar Klein , Mark Bloch , Or Gerlitz To: Paul Blakey Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:34982 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbeFDRwF (ORCPT ); Mon, 4 Jun 2018 13:52:05 -0400 Received: by mail-wm0-f68.google.com with SMTP id j15-v6so2648wme.0 for ; Mon, 04 Jun 2018 10:52:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1528009574-63306-2-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Jun 03, 2018 at 10:06:14AM +0300, Paul Blakey wrote: > We incorrectly compare the mask and the result is that we can't modify > an already existing rule. > > Fix that by comparing correctly. > > Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") > Reported-by: Vlad Buslov > Reviewed-by: Roi Dayan > Reviewed-by: Jiri Pirko > Signed-off-by: Paul Blakey Reviewed-by: Simon Horman