From: David Miller <davem@davemloft.net>
To: paulb@mellanox.com
Cc: jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
netdev@vger.kernel.org, kliteyn@mellanox.com, roid@mellanox.com,
shahark@mellanox.com, markb@mellanox.com, ogerlitz@mellanox.com
Subject: Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan
Date: Tue, 05 Jun 2018 10:30:31 -0400 (EDT) [thread overview]
Message-ID: <20180605.103031.2043903448130876802.davem@davemloft.net> (raw)
In-Reply-To: <1528185843-18645-1-git-send-email-paulb@mellanox.com>
From: Paul Blakey <paulb@mellanox.com>
Date: Tue, 5 Jun 2018 11:04:03 +0300
> When using a vxlan device as the ingress dev, we count it as a
> "no offload dev", so when such a rule comes and err stop is true,
> we fail early and don't try the egdev route which can offload it
> through the egress device.
>
> Fix that by not calling the block offload if one of the devices
> attached to it is not offload capable, but make sure egress on such case
> is capable instead.
>
> Fixes: caa7260156eb ("net: sched: keep track of offloaded filters [..]")
> Reviewed-by: Roi Dayan <roid@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Paul Blakey <paulb@mellanox.com>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2018-06-05 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 8:04 [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan Paul Blakey
2018-06-05 14:30 ` David Miller [this message]
2018-06-05 18:57 ` Jakub Kicinski
2018-06-05 18:59 ` Jakub Kicinski
2018-06-06 5:12 ` Or Gerlitz
2018-06-06 15:50 ` Jakub Kicinski
2018-06-06 19:07 ` Or Gerlitz
2018-06-05 19:06 ` David Miller
2018-06-05 21:27 ` Jakub Kicinski
2018-06-06 5:15 ` Or Gerlitz
2018-06-06 15:46 ` Jakub Kicinski
2018-06-06 7:59 ` Paul Blakey
2018-06-06 15:57 ` Jakub Kicinski
2018-06-06 17:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605.103031.2043903448130876802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kliteyn@mellanox.com \
--cc=markb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=shahark@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).