From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: pablo@netfilter.org, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, ecklm94@gmail.com, pabeni@redhat.com,
willemb@google.com, edumazet@google.com, dsahern@gmail.com,
kafai@fb.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: provide udp*_lib_lookup for nf_tproxy
Date: Tue, 05 Jun 2018 10:54:53 -0400 (EDT) [thread overview]
Message-ID: <20180605.105453.339908802413146875.davem@davemloft.net> (raw)
In-Reply-To: <20180605114056.1239571-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 5 Jun 2018 13:40:34 +0200
> It is now possible to enable the libified nf_tproxy modules without
> also enabling NETFILTER_XT_TARGET_TPROXY, which throws off the
> ifdef logic in the udp core code:
>
> net/ipv6/netfilter/nf_tproxy_ipv6.o: In function `nf_tproxy_get_sock_v6':
> nf_tproxy_ipv6.c:(.text+0x1a8): undefined reference to `udp6_lib_lookup'
> net/ipv4/netfilter/nf_tproxy_ipv4.o: In function `nf_tproxy_get_sock_v4':
> nf_tproxy_ipv4.c:(.text+0x3d0): undefined reference to `udp4_lib_lookup'
>
> We can actually simplify the conditions now to provide the two functions
> exactly when they are needed.
>
> Fixes: 45ca4e0cf273 ("netfilter: Libify xt_TPROXY")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Pablo, I'm going to apply this directly to fix the link failure.
Thanks Arnd.
next prev parent reply other threads:[~2018-06-05 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 11:40 [PATCH] netfilter: provide udp*_lib_lookup for nf_tproxy Arnd Bergmann
2018-06-05 12:13 ` Paolo Abeni
2018-06-05 14:42 ` Eckl, Máté
2018-06-05 14:54 ` David Miller [this message]
2018-06-05 15:12 ` Pablo Neira Ayuso
2018-06-06 13:33 ` Pablo Neira Ayuso
2018-06-07 20:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605.105453.339908802413146875.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=dsahern@gmail.com \
--cc=ecklm94@gmail.com \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).