From: Stephen Hemminger <stephen@networkplumber.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2 1/2] ip: display netns name instead of nsid
Date: Tue, 5 Jun 2018 09:52:24 -0700 [thread overview]
Message-ID: <20180605095224.1921fee5@xeon-e3> (raw)
In-Reply-To: <20180605130831.8175-2-nicolas.dichtel@6wind.com>
On Tue, 5 Jun 2018 15:08:30 +0200
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
>
> +char *get_name_from_nsid(int nsid)
> +{
> + struct nsid_cache *c;
> +
> + netns_nsid_socket_init();
> + netns_map_init();
> +
> + c = netns_map_get_by_nsid(nsid);
> + if (c)
> + return c->name;
> +
> + return NULL;
> +}
> +
This is better, but now there is a different problem.
When doing multiple interfaces, won't the initialization code be called twice?
next prev parent reply other threads:[~2018-06-05 16:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 14:28 [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support Nicolas Dichtel
2018-05-31 14:31 ` Nicolas Dichtel
2018-05-31 15:46 ` Stephen Hemminger
2018-05-31 15:51 ` Nicolas Dichtel
2018-06-01 15:02 ` Nicolas Dichtel
2018-06-01 20:02 ` Stephen Hemminger
2018-06-04 12:12 ` [PATCH iproute2 0/2] display netns name instead of nsid Nicolas Dichtel
2018-06-04 12:12 ` [PATCH iproute2 1/2] ip: " Nicolas Dichtel
2018-06-04 21:12 ` Stephen Hemminger
2018-06-05 13:08 ` [PATCH iproute2 v2 0/2] " Nicolas Dichtel
2018-06-05 13:08 ` [PATCH iproute2 v2 1/2] ip: " Nicolas Dichtel
2018-06-05 16:52 ` Stephen Hemminger [this message]
2018-06-06 7:11 ` Nicolas Dichtel
2018-06-05 13:08 ` [PATCH iproute2 v2 2/2] iplink: enable to specify a name for the link-netns Nicolas Dichtel
2018-06-08 17:08 ` [PATCH iproute2 v2 0/2] display netns name instead of nsid Stephen Hemminger
2018-06-04 12:12 ` [PATCH iproute2 2/2] iplink: enable to specify a name for the link-netns Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605095224.1921fee5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).