From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next v2 1/1] tc: add json support in csum
 action
Date: Tue, 5 Jun 2018 14:10:11 -0700
Message-ID: <20180605141011.144bd604@xeon-e3>
References: <1528231459-26546-1-git-send-email-kleib@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dsahern@gmail.com, netdev@vger.kernel.org, kernel@mojatatu.com
To: Keara Leibovitz <kleib@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f194.google.com ([209.85.192.194]:44116 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751619AbeFEVQk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Jun 2018 17:16:40 -0400
Received: by mail-pf0-f194.google.com with SMTP id h12-v6so1972399pfk.11
        for <netdev@vger.kernel.org>; Tue, 05 Jun 2018 14:16:40 -0700 (PDT)
In-Reply-To: <1528231459-26546-1-git-send-email-kleib@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue,  5 Jun 2018 16:44:19 -0400
Keara Leibovitz <kleib@mojatatu.com> wrote:

> diff --git a/tc/m_csum.c b/tc/m_csum.c
> index 8391071d73f2..0bdbcf361a28 100644
> --- a/tc/m_csum.c
> +++ b/tc/m_csum.c
> @@ -162,6 +162,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr *arg)
>  	char *uflag_5 = "";
>  	char *uflag_6 = "";
>  	char *uflag_7 = "";
> +	char buf[64];

Looks good.
In iproute2 the common macro for declaring these kind of buffers is:
	SPRINT_BUF(buf);

Doesn't matter that much, but nice to have consistency.