From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: provide udp*_lib_lookup for nf_tproxy Date: Tue, 5 Jun 2018 17:12:37 +0200 Message-ID: <20180605151237.x6u3l3ssgzn2b6gb@salvia> References: <20180605114056.1239571-1-arnd@arndb.de> <20180605.105453.339908802413146875.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: arnd@arndb.de, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, ecklm94@gmail.com, pabeni@redhat.com, willemb@google.com, edumazet@google.com, dsahern@gmail.com, kafai@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: Received: from mail.us.es ([193.147.175.20]:40470 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbeFEPMn (ORCPT ); Tue, 5 Jun 2018 11:12:43 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id ADAC6174D2B for ; Tue, 5 Jun 2018 17:11:27 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9B03DDA4C1 for ; Tue, 5 Jun 2018 17:11:27 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180605.105453.339908802413146875.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jun 05, 2018 at 10:54:53AM -0400, David Miller wrote: > From: Arnd Bergmann > Date: Tue, 5 Jun 2018 13:40:34 +0200 > > > It is now possible to enable the libified nf_tproxy modules without > > also enabling NETFILTER_XT_TARGET_TPROXY, which throws off the > > ifdef logic in the udp core code: > > > > net/ipv6/netfilter/nf_tproxy_ipv6.o: In function `nf_tproxy_get_sock_v6': > > nf_tproxy_ipv6.c:(.text+0x1a8): undefined reference to `udp6_lib_lookup' > > net/ipv4/netfilter/nf_tproxy_ipv4.o: In function `nf_tproxy_get_sock_v4': > > nf_tproxy_ipv4.c:(.text+0x3d0): undefined reference to `udp4_lib_lookup' > > > > We can actually simplify the conditions now to provide the two functions > > exactly when they are needed. > > > > Fixes: 45ca4e0cf273 ("netfilter: Libify xt_TPROXY") > > Signed-off-by: Arnd Bergmann > > Pablo, I'm going to apply this directly to fix the link failure. > > Thanks Arnd. Thanks David.