From: David Miller <davem@davemloft.net>
To: kubakici@wp.pl
Cc: paulb@mellanox.com, jiri@mellanox.com, xiyou.wangcong@gmail.com,
jhs@mojatatu.com, netdev@vger.kernel.org, kliteyn@mellanox.com,
roid@mellanox.com, shahark@mellanox.com, markb@mellanox.com,
ogerlitz@mellanox.com
Subject: Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan
Date: Wed, 06 Jun 2018 13:56:56 -0400 (EDT) [thread overview]
Message-ID: <20180606.135656.244851221815982824.davem@davemloft.net> (raw)
In-Reply-To: <20180605142700.6033a7a0@cakuba.netronome.com>
From: Jakub Kicinski <kubakici@wp.pl>
Date: Tue, 5 Jun 2018 14:27:00 -0700
> On Tue, 05 Jun 2018 15:06:40 -0400 (EDT), David Miller wrote:
>> From: Jakub Kicinski <kubakici@wp.pl>
>> Date: Tue, 5 Jun 2018 11:57:47 -0700
>>
>> > Do we still care about correctness and not breaking backward
>> > compatibility?
>>
>> Jakub let me know if you want me to revert this change.
>
> Yes, I think this patch introduces a regression when block is shared
> between offload capable and in-capable device, therefore it should be
> reverted.
Ok, I've reverted the change. Please sort out how to fix things
properly.
prev parent reply other threads:[~2018-06-06 17:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 8:04 [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan Paul Blakey
2018-06-05 14:30 ` David Miller
2018-06-05 18:57 ` Jakub Kicinski
2018-06-05 18:59 ` Jakub Kicinski
2018-06-06 5:12 ` Or Gerlitz
2018-06-06 15:50 ` Jakub Kicinski
2018-06-06 19:07 ` Or Gerlitz
2018-06-05 19:06 ` David Miller
2018-06-05 21:27 ` Jakub Kicinski
2018-06-06 5:15 ` Or Gerlitz
2018-06-06 15:46 ` Jakub Kicinski
2018-06-06 7:59 ` Paul Blakey
2018-06-06 15:57 ` Jakub Kicinski
2018-06-06 17:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606.135656.244851221815982824.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kliteyn@mellanox.com \
--cc=kubakici@wp.pl \
--cc=markb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=shahark@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).