From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan Date: Wed, 06 Jun 2018 13:56:56 -0400 (EDT) Message-ID: <20180606.135656.244851221815982824.davem@davemloft.net> References: <20180605115747.0e939ac4@cakuba.netronome.com> <20180605.150640.12956507851401975.davem@davemloft.net> <20180605142700.6033a7a0@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: paulb@mellanox.com, jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, netdev@vger.kernel.org, kliteyn@mellanox.com, roid@mellanox.com, shahark@mellanox.com, markb@mellanox.com, ogerlitz@mellanox.com To: kubakici@wp.pl Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933672AbeFFR47 (ORCPT ); Wed, 6 Jun 2018 13:56:59 -0400 In-Reply-To: <20180605142700.6033a7a0@cakuba.netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Tue, 5 Jun 2018 14:27:00 -0700 > On Tue, 05 Jun 2018 15:06:40 -0400 (EDT), David Miller wrote: >> From: Jakub Kicinski >> Date: Tue, 5 Jun 2018 11:57:47 -0700 >> >> > Do we still care about correctness and not breaking backward >> > compatibility? >> >> Jakub let me know if you want me to revert this change. > > Yes, I think this patch introduces a regression when block is shared > between offload capable and in-capable device, therefore it should be > reverted. Ok, I've reverted the change. Please sort out how to fix things properly.