From: David Miller <davem@davemloft.net>
To: Julia.Lawall@lip6.fr
Cc: ariel.elior@cavium.com, kernel-janitors@vger.kernel.org,
everest-linux-l2@cavium.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2x: use the right constant
Date: Wed, 06 Jun 2018 14:01:35 -0400 (EDT) [thread overview]
Message-ID: <20180606.140135.1343207157647295023.davem@davemloft.net> (raw)
In-Reply-To: <1528290202-32454-1-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Wed, 6 Jun 2018 15:03:22 +0200
> Nearby code that also tests port suggests that the P0 constant should be
> used when port is zero.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e,e1;
> @@
>
> * e ? e1 : e1
> // </smpl>
>
> Fixes: 6c3218c6f7e5 ("bnx2x: Adjust ETS to 578xx")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
This definitely looks correct. Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2018-06-06 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 13:03 [PATCH] bnx2x: use the right constant Julia Lawall
2018-06-06 18:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606.140135.1343207157647295023.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Julia.Lawall@lip6.fr \
--cc=ariel.elior@cavium.com \
--cc=everest-linux-l2@cavium.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).