From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] strparser: Add __strp_unpause and use it in ktls. Date: Wed, 06 Jun 2018 14:08:20 -0400 (EDT) Message-ID: <20180606.140820.861661277537600504.davem@davemloft.net> References: <20180606163328.757943-1-doronrk@fb.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: davejwatson@fb.com, tom@quantonium.net, vakul.garg@nxp.com, netdev@vger.kernel.org To: doronrk@fb.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45602 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbeFFSIX (ORCPT ); Wed, 6 Jun 2018 14:08:23 -0400 In-Reply-To: <20180606163328.757943-1-doronrk@fb.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Doron Roberts-Kedes Date: Wed, 6 Jun 2018 09:33:28 -0700 > strp_unpause queues strp_work in order to parse any messages that > arrived while the strparser was paused. However, the process invoking > strp_unpause could eagerly parse a buffered message itself if it held > the sock lock. > > __strp_unpause is an alternative to strp_pause that avoids the scheduling > overhead that results when a receiving thread unpauses the strparser > and waits for the next message to be delivered by the workqueue thread. > > This patch more than doubled the IOPS achieved in a benchmark of NBD > traffic encrypted using ktls. > > Signed-off-by: Doron Roberts-Kedes Applied, thank you.