From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net] failover: eliminate callback hell
Date: Wed, 6 Jun 2018 09:25:12 +0200
Message-ID: <20180606072512.GA2289@nanopsycho.orion>
References: <20180605034231.31610-1-sthemmin@microsoft.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kys@microsoft.com, haiyangz@microsoft.com, davem@davemloft.net,
        mst@redhat.com, sridhar.samudrala@intel.com,
        netdev@vger.kernel.org, Stephen Hemminger <sthemmin@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f193.google.com ([209.85.128.193]:46922 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932248AbeFFHZu (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 6 Jun 2018 03:25:50 -0400
Received: by mail-wr0-f193.google.com with SMTP id v13-v6so5052108wrp.13
        for <netdev@vger.kernel.org>; Wed, 06 Jun 2018 00:25:50 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180605034231.31610-1-sthemmin@microsoft.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Tue, Jun 05, 2018 at 05:42:31AM CEST, stephen@networkplumber.org wrote:
>The net failover should be a simple library, not a virtual
>object with function callbacks (see callback hell).

Why just a library? It should do a common things. I think it should be a
virtual object. Looks like your patch again splits the common
functionality into multiple drivers. That is kind of backwards attitude.
I don't get it. We should rather focus on fixing the mess the
introduction of netvsc-bonding caused and switch netvsc to 3-netdev
model.