From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH bpf-next v5 2/2] samples/bpf: Add xdp_sample_pkts example Date: Wed, 6 Jun 2018 09:54:24 -0700 Message-ID: <20180606095424.5921636f@cakuba.netronome.com> References: <152828901936.9599.10143519677183418086.stgit@alrua-kau> <152828901941.9599.5391551130846011457.stgit@alrua-kau> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:34363 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000AbeFFQy2 (ORCPT ); Wed, 6 Jun 2018 12:54:28 -0400 Received: by mail-pl0-f66.google.com with SMTP id g20-v6so4192352plq.1 for ; Wed, 06 Jun 2018 09:54:28 -0700 (PDT) In-Reply-To: <152828901941.9599.5391551130846011457.stgit@alrua-kau> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 06 Jun 2018 14:43:39 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Add an example program showing how to sample packets from XDP using the > perf event buffer. The example userspace program just prints the ethernet > header for every packet sampled. >=20 > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen Looks like some of the includes in samples/bpf/xdp_sample_pkts_user.c are unnecessary, but otherwise LGTM. Reviewed-by: Jakub Kicinski