From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] r8169: Reinstate ALDPS and ASPM support
Date: Wed, 6 Jun 2018 14:34:25 +0200
Message-ID: <20180606123425.GA14898@lunn.ch>
References: <20180605045812.17977-1-kai.heng.feng@canonical.com>
 <20180605141114.GC14873@lunn.ch>
 <8BAED2AC-DA94-4F63-BA16-EB3D54649BC5@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        Hayes Wang <hayeswang@realtek.com>, hkallweit1@gmail.com,
        romieu@fr.zoreil.com, Linux Netdev List <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ryankao <ryankao@realtek.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <8BAED2AC-DA94-4F63-BA16-EB3D54649BC5@canonical.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

> Hi Andrew,
> 
> Sure.
> 
> Do you think we should also strip out the enable/disable logic?
> 
> Or just remove the parameter?

Hi Kai-Heng

How would you use the logic if you remove the parameter?

    Andrew