From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net] failover: eliminate callback hell
Date: Wed, 6 Jun 2018 14:17:16 -0700
Message-ID: <20180606141716.7ee562e1@xeon-e3>
References: <20180605034231.31610-1-sthemmin@microsoft.com>
        <20180605211927-mutt-send-email-mst@kernel.org>
        <20180605115305.502a7ebb@xeon-e3>
        <20180605221049-mutt-send-email-mst@kernel.org>
        <20180605145222.477e5ae8@xeon-e3>
        <cea68d90-5ebf-78b1-7476-d88ae72dcfb6@intel.com>
        <20180605205118.439a7873@xeon-e3>
        <20180606151019-mutt-send-email-mst@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
        kys@microsoft.com, haiyangz@microsoft.com, davem@davemloft.net,
        netdev@vger.kernel.org, Stephen Hemminger <sthemmin@microsoft.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:45603 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752056AbeFFWoN (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 6 Jun 2018 18:44:13 -0400
Received: by mail-pl0-f65.google.com with SMTP id c23-v6so4705521plz.12
        for <netdev@vger.kernel.org>; Wed, 06 Jun 2018 15:44:13 -0700 (PDT)
In-Reply-To: <20180606151019-mutt-send-email-mst@kernel.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 6 Jun 2018 15:19:30 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Tue, Jun 05, 2018 at 08:51:18PM -0700, Stephen Hemminger wrote:
> > > I think the push back was with the usage of the delay, not bringing up the primary/standby
> > > device in the name change event handler.
> > > Can't netvsc use this mechanism instead of depending on the delay?
> > > 
> > >   
> > 
> > The patch that was rejected for netvsc was about using name change.  
> 
> So failover is now doing exactly what you wanted netvsc to do.  Rather
> than reverting everyone to old behaviour how about using more pieces
> from failover?
> 
> > Also, you can't depend on name change; you still need a timer. Not all distributions
> > change name of devices.  
> 
> So failover chose not to implement the delayed open so far.
> If it does I suspect we'll have to keep it around forever -
> kind of like netvsc seems to be stuck with it.
> But let's see if there's enough actual demand from people running
> ancient distros with latest kernels to even start looking for
> a solution for failover.
> 
> And this kind of behaviour change really should be split out
> so we can discuss it separately.
> 
> > Or user has blocked that by udev rules.  
> 
> Don't do that then?
> 

If you don't want to allow udev to rename the device, then just pull
the name change hook.