From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net] failover: eliminate callback hell Date: Wed, 6 Jun 2018 14:26:30 -0700 Message-ID: <20180606142630.050641fd@xeon-e3> References: <20180605034231.31610-1-sthemmin@microsoft.com> <20180606072512.GA2289@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: kys@microsoft.com, haiyangz@microsoft.com, davem@davemloft.net, mst@redhat.com, sridhar.samudrala@intel.com, netdev@vger.kernel.org, Stephen Hemminger To: Jiri Pirko Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:37196 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094AbeFFV0d (ORCPT ); Wed, 6 Jun 2018 17:26:33 -0400 Received: by mail-pg0-f66.google.com with SMTP id r21-v6so3288910pgv.4 for ; Wed, 06 Jun 2018 14:26:33 -0700 (PDT) In-Reply-To: <20180606072512.GA2289@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 6 Jun 2018 09:25:12 +0200 Jiri Pirko wrote: > Tue, Jun 05, 2018 at 05:42:31AM CEST, stephen@networkplumber.org wrote: > >The net failover should be a simple library, not a virtual > >object with function callbacks (see callback hell). > > Why just a library? It should do a common things. I think it should be a > virtual object. Looks like your patch again splits the common > functionality into multiple drivers. That is kind of backwards attitude. > I don't get it. We should rather focus on fixing the mess the > introduction of netvsc-bonding caused and switch netvsc to 3-netdev > model. To me, callbacks are worse than a simple notifier. Is there some other agenda going on? do you want to get rid of network notifier. Netvsc is not switching to 3 device model in near future. Too much userspace is wrapped around it already.