netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: decui@microsoft.com
Cc: jopoulso@microsoft.com, olaf@aepfle.de, sthemmin@microsoft.com,
	netdev@vger.kernel.org, haiyangz@microsoft.com,
	linux-kernel@vger.kernel.org, marcelo.cerri@canonical.com,
	apw@canonical.com, devel@linuxdriverproject.org,
	vkuznets@redhat.com, jasowang@redhat.com,
	Stephen.Zarkos@microsoft.com
Subject: Re: [PATCH v2] hv_netvsc: Fix a network regression after ifdown/ifup
Date: Thu, 07 Jun 2018 16:24:43 -0400 (EDT)	[thread overview]
Message-ID: <20180607.162443.917679158498262601.davem@davemloft.net> (raw)
In-Reply-To: <KL1P15301MB00062D55F01921B958359A55BF650@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM>

From: Dexuan Cui <decui@microsoft.com>
Date: Wed, 6 Jun 2018 21:32:51 +0000

> 
> Recently people reported the NIC stops working after
> "ifdown eth0; ifup eth0". It turns out in this case the TX queues are not
> enabled, after the refactoring of the common detach logic: when the NIC
> has sub-channels, usually we enable all the TX queues after all
> sub-channels are set up: see rndis_set_subchannel() ->
> netif_device_attach(), but in the case of "ifdown eth0; ifup eth0" where
> the number of channels doesn't change, we also must make sure the TX queues
> are enabled. The patch fixes the regression.
> 
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> Signed-off-by: Dexuan Cui <decui@microsoft.com>

Applied and queued up for -stable.

      reply	other threads:[~2018-06-07 20:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 21:32 [PATCH v2] hv_netvsc: Fix a network regression after ifdown/ifup Dexuan Cui
2018-06-07 20:24 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607.162443.917679158498262601.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Stephen.Zarkos@microsoft.com \
    --cc=apw@canonical.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=jasowang@redhat.com \
    --cc=jopoulso@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).