From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] hv_netvsc: Fix a network regression after ifdown/ifup Date: Thu, 07 Jun 2018 16:24:43 -0400 (EDT) Message-ID: <20180607.162443.917679158498262601.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: jopoulso@microsoft.com, olaf@aepfle.de, sthemmin@microsoft.com, netdev@vger.kernel.org, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, marcelo.cerri@canonical.com, apw@canonical.com, devel@linuxdriverproject.org, vkuznets@redhat.com, jasowang@redhat.com, Stephen.Zarkos@microsoft.com To: decui@microsoft.com Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org From: Dexuan Cui Date: Wed, 6 Jun 2018 21:32:51 +0000 > > Recently people reported the NIC stops working after > "ifdown eth0; ifup eth0". It turns out in this case the TX queues are not > enabled, after the refactoring of the common detach logic: when the NIC > has sub-channels, usually we enable all the TX queues after all > sub-channels are set up: see rndis_set_subchannel() -> > netif_device_attach(), but in the case of "ifdown eth0; ifup eth0" where > the number of channels doesn't change, we also must make sure the TX queues > are enabled. The patch fixes the regression. > > Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic") > Signed-off-by: Dexuan Cui Applied and queued up for -stable.